nix/tests/flakes
Maximilian Bosch 559fd7ffe7
nix flake check: improve error message if overlay is not a lambda (#8582)
* nix flake check: improve error message if overlay is not a lambda

Suppose you have an overlay like this

    {
      inputs = { /* ... */ };
      outputs = { flake-utils, ... }: flake-utils.lib.eachDefaultSystem
        (system: {
          overlays.default = final: prev: {

          };
        });
    }

then `nix flake check` (correctly) fails because `overlays` are supposed
to have the structure `overlays.<name> = final: prev: exp`. However, the
error-message is a little bit counter-intuitive:

    error: overlay does not take an argument named 'final'

While one might guess where the error actually comes from because the
trace above says `… while checking the overlay 'overlays.x86_64-linux'`
this is still pretty confusing because it complains about an argument
not being named `final` even though that's evidently the case.

With this change, the error-message actually makes it clear what's
wrong:

    [ma27@carsten:~/Projects/nix/tmp]$ nix flake check --extra-experimental-features 'nix-command flakes' path:$(pwd)
    error:
           … while checking flake output 'overlays'

             at /nix/store/clgblnxx003hyrq8qkz5ab6kgqkck6qc-source/flake.nix:4:5:

                3|   outputs = { ... }: {
                4|     overlays.x86_64-linux.snens = final: prev: {
                 |     ^
                5|       kek = throw "snens";

           … while checking the overlay 'overlays.x86_64-linux'

             at /nix/store/clgblnxx003hyrq8qkz5ab6kgqkck6qc-source/flake.nix:4:5:

                3|   outputs = { ... }: {
                4|     overlays.x86_64-linux.snens = final: prev: {
                 |     ^
                5|       kek = throw "snens";

           error: overlay is not a lambda, but a set instead
2023-06-27 14:58:29 +02:00
..
absolute-paths.sh Trivial changes from the lazy-trees branch 2022-12-07 14:06:34 +01:00
build-paths.sh Make more string values work as installables 2023-05-15 09:03:38 -04:00
bundle.sh Move the 'nix bundle' tests 2022-07-13 20:49:07 +02:00
check.sh nix flake check: improve error message if overlay is not a lambda (#8582) 2023-06-27 14:58:29 +02:00
circular.sh Split off the circular flake import tests 2022-07-13 20:37:32 +02:00
common.sh Cleanup test skipping 2023-03-16 18:43:03 -04:00
config.sh Move flake-local-settings.sh 2022-07-13 20:51:28 +02:00
flake-in-submodule.sh tests/flake-in-submodule: Remove unnecessary rm -rf 2023-03-18 14:39:38 +01:00
flakes.sh Add dirtyRev and dirtyShortRev to fetchGit 2023-06-24 14:17:25 +10:00
follow-paths.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
init.sh Fix the flakes init test 2023-01-30 11:21:52 +01:00
inputs.sh flakes: Differentiate self.outPath and self.sourceInfo.outPath 2023-02-22 03:31:24 +01:00
mercurial.sh Cleanup test skipping 2023-03-16 18:43:03 -04:00
run.sh Move flakes tests to a subdirectory 2022-07-13 15:06:54 +02:00
search-root.sh Move flake-searching.sh and make it less dependent on git 2022-07-13 20:55:17 +02:00
show.sh tests/flakes/show.sh: Broaden requirement comment 2023-03-27 05:11:23 +02:00
unlocked-override.sh Trivial changes from the lazy-trees branch 2022-12-07 14:06:34 +01:00