mirror of
https://github.com/NixOS/nix.git
synced 2024-11-22 14:52:55 +00:00
61a4d3d45c
This makes it possible to certain discern failures from empty snippets, which I think is an ok review comment. Maybe it should do so for swapped column indexes too, but I'm not sure. I don't think it matters in the grand scheme. We don't even have a real use case for `nullopt` now anyway. Since we don't have a use case, I'm not applying this logic to higher level functions yet.
123 lines
3.4 KiB
C++
123 lines
3.4 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include "position.hh"
|
|
|
|
namespace nix {
|
|
|
|
inline Pos::Origin makeStdin(std::string s)
|
|
{
|
|
return Pos::Stdin{make_ref<std::string>(s)};
|
|
}
|
|
|
|
TEST(Position, getSnippetUpTo_0)
|
|
{
|
|
Pos::Origin o = makeStdin("");
|
|
Pos p(1, 1, o);
|
|
ASSERT_EQ(p.getSnippetUpTo(p), "");
|
|
}
|
|
TEST(Position, getSnippetUpTo_1)
|
|
{
|
|
Pos::Origin o = makeStdin("x");
|
|
{
|
|
// NOTE: line and column are actually 1-based indexes
|
|
Pos start(0, 0, o);
|
|
Pos end(99, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(start), "");
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "x");
|
|
ASSERT_EQ(end.getSnippetUpTo(end), "");
|
|
ASSERT_EQ(end.getSnippetUpTo(start), std::nullopt);
|
|
}
|
|
{
|
|
// NOTE: line and column are actually 1-based indexes
|
|
Pos start(0, 99, o);
|
|
Pos end(99, 0, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(start), "");
|
|
|
|
// "x" might be preferable, but we only care about not crashing for invalid inputs
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "");
|
|
|
|
ASSERT_EQ(end.getSnippetUpTo(end), "");
|
|
ASSERT_EQ(end.getSnippetUpTo(start), std::nullopt);
|
|
}
|
|
{
|
|
Pos start(1, 1, o);
|
|
Pos end(1, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(start), "");
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "x");
|
|
ASSERT_EQ(end.getSnippetUpTo(end), "");
|
|
ASSERT_EQ(end.getSnippetUpTo(start), "");
|
|
}
|
|
{
|
|
Pos start(1, 1, o);
|
|
Pos end(99, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(start), "");
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "x");
|
|
ASSERT_EQ(end.getSnippetUpTo(end), "");
|
|
ASSERT_EQ(end.getSnippetUpTo(start), std::nullopt);
|
|
}
|
|
}
|
|
TEST(Position, getSnippetUpTo_2)
|
|
{
|
|
Pos::Origin o = makeStdin("asdf\njkl\nqwer");
|
|
{
|
|
Pos start(1, 1, o);
|
|
Pos end(1, 2, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(start), "");
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "a");
|
|
ASSERT_EQ(end.getSnippetUpTo(end), "");
|
|
|
|
// nullopt? I feel like changing the column handling would just make it more fragile
|
|
ASSERT_EQ(end.getSnippetUpTo(start), "");
|
|
}
|
|
{
|
|
Pos start(1, 2, o);
|
|
Pos end(1, 3, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "s");
|
|
}
|
|
{
|
|
Pos start(1, 2, o);
|
|
Pos end(2, 2, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "sdf\nj");
|
|
}
|
|
{
|
|
Pos start(1, 2, o);
|
|
Pos end(3, 2, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "sdf\njkl\nq");
|
|
}
|
|
{
|
|
Pos start(1, 2, o);
|
|
Pos end(2, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "sdf\njkl");
|
|
}
|
|
{
|
|
Pos start(1, 4, o);
|
|
Pos end(2, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "f\njkl");
|
|
}
|
|
{
|
|
Pos start(1, 5, o);
|
|
Pos end(2, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "\njkl");
|
|
}
|
|
{
|
|
Pos start(1, 6, o); // invalid: starting column past last "line character", ie at the newline
|
|
Pos end(2, 99, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "\njkl"); // jkl might be acceptable for this invalid start position
|
|
}
|
|
{
|
|
Pos start(1, 1, o);
|
|
Pos end(2, 0, o); // invalid
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "asdf\n");
|
|
}
|
|
}
|
|
|
|
TEST(Position, example_1)
|
|
{
|
|
Pos::Origin o = makeStdin(" unambiguous = \n /** Very close */\n x: x;\n# ok\n");
|
|
Pos start(2, 5, o);
|
|
Pos end(2, 22, o);
|
|
ASSERT_EQ(start.getSnippetUpTo(end), "/** Very close */");
|
|
}
|
|
|
|
} // namespace nix
|