mirror of
https://github.com/NixOS/nix.git
synced 2024-11-22 14:52:55 +00:00
a61e42adb5
Today, with the tests inside a `tests` intermingled with the
corresponding library's source code, we have a few problems:
- We have to be careful that wildcards don't end up with tests being
built as part of Nix proper, or test headers being installed as part
of Nix proper.
- Tests in libraries but not executables is not right:
- It means each executable runs the previous unit tests again, because
it needs the libraries.
- It doesn't work right on Windows, which doesn't want you to load a
DLL just for the side global variable . It could be made to work
with the dlopen equivalent, but that's gross!
This reorg solves these problems.
There is a remaining problem which is that sibbling headers (like
`hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end
up shadowing each other. This PR doesn't solve that. That is left as
future work for a future PR.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
(cherry picked from commit 91b6833686)
93 lines
3.3 KiB
Makefile
93 lines
3.3 KiB
Makefile
programs-list :=
|
||
|
||
# Build a program with symbolic name $(1). The program is defined by
|
||
# various variables prefixed by ‘$(1)_’:
|
||
#
|
||
# - $(1)_NAME: the name of the program (e.g. ‘foo’); defaults to
|
||
# $(1).
|
||
#
|
||
# - $(1)_DIR: the directory where the (non-installed) program will be
|
||
# placed.
|
||
#
|
||
# - $(1)_SOURCES: the source files of the program.
|
||
#
|
||
# - $(1)_CFLAGS: additional C compiler flags.
|
||
#
|
||
# - $(1)_CXXFLAGS: additional C++ compiler flags.
|
||
#
|
||
# - $(1)_ORDER_AFTER: a set of targets on which the object files of
|
||
# this program will have an order-only dependency.
|
||
#
|
||
# - $(1)_LIBS: the symbolic names of libraries on which this program
|
||
# depends.
|
||
#
|
||
# - $(1)_LDFLAGS: additional linker flags.
|
||
#
|
||
# - $(1)_INSTALL_DIR: the directory where the program will be
|
||
# installed; defaults to $(bindir).
|
||
define build-program
|
||
$(1)_NAME ?= $(1)
|
||
_d := $(buildprefix)$$($(1)_DIR)
|
||
_srcs := $$(sort $$(foreach src, $$($(1)_SOURCES), $$(src)))
|
||
$(1)_OBJS := $$(addprefix $(buildprefix), $$(addsuffix .o, $$(basename $$(_srcs))))
|
||
_libs := $$(foreach lib, $$($(1)_LIBS), $$(foreach lib2, $$($$(lib)_LIB_CLOSURE), $$($$(lib2)_PATH)))
|
||
$(1)_PATH := $$(_d)/$$($(1)_NAME)
|
||
|
||
$$(eval $$(call create-dir, $$(_d)))
|
||
|
||
$$($(1)_PATH): $$($(1)_OBJS) $$(_libs) | $$(_d)/
|
||
+$$(trace-ld) $(CXX) -o $$@ $$(LDFLAGS) $$(GLOBAL_LDFLAGS) $$($(1)_OBJS) $$($(1)_LDFLAGS) $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_LDFLAGS_USE))
|
||
|
||
$(1)_INSTALL_DIR ?= $$(bindir)
|
||
|
||
ifdef $(1)_INSTALL_DIR
|
||
|
||
$(1)_INSTALL_PATH := $$($(1)_INSTALL_DIR)/$$($(1)_NAME)
|
||
|
||
$$(eval $$(call create-dir, $$($(1)_INSTALL_DIR)))
|
||
|
||
install: $(DESTDIR)$$($(1)_INSTALL_PATH)
|
||
|
||
ifeq ($(BUILD_SHARED_LIBS), 1)
|
||
|
||
_libs_final := $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_INSTALL_PATH))
|
||
|
||
$(DESTDIR)$$($(1)_INSTALL_PATH): $$($(1)_OBJS) $$(_libs_final) | $(DESTDIR)$$($(1)_INSTALL_DIR)/
|
||
+$$(trace-ld) $(CXX) -o $$@ $$(LDFLAGS) $$(GLOBAL_LDFLAGS) $$($(1)_OBJS) $$($(1)_LDFLAGS) $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_LDFLAGS_USE_INSTALLED))
|
||
|
||
else
|
||
|
||
$(DESTDIR)$$($(1)_INSTALL_PATH): $$($(1)_PATH) | $(DESTDIR)$$($(1)_INSTALL_DIR)/
|
||
+$$(trace-install) install -t $(DESTDIR)$$($(1)_INSTALL_DIR) $$<
|
||
|
||
endif
|
||
endif
|
||
|
||
# Propagate CFLAGS and CXXFLAGS to the individual object files.
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj)_CFLAGS=$$($(1)_CFLAGS)))
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj)_CXXFLAGS=$$($(1)_CXXFLAGS)))
|
||
|
||
# Make each object file depend on the common dependencies.
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj): $$($(1)_COMMON_DEPS) $$(GLOBAL_COMMON_DEPS)))
|
||
|
||
# Make each object file have order-only dependencies on the common
|
||
# order-only dependencies. This includes the order-only dependencies
|
||
# of libraries we're depending on.
|
||
$(1)_ORDER_AFTER_CLOSED = $$($(1)_ORDER_AFTER) $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_ORDER_AFTER_CLOSED))
|
||
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj): | $$($(1)_ORDER_AFTER_CLOSED) $$(GLOBAL_ORDER_AFTER)))
|
||
|
||
# Include .dep files, if they exist.
|
||
$(1)_DEPS := $$(foreach fn, $$($(1)_OBJS), $$(call filename-to-dep, $$(fn)))
|
||
-include $$($(1)_DEPS)
|
||
|
||
programs-list += $$($(1)_PATH)
|
||
clean-files += $$($(1)_PATH) $$(_d)/*.o $$(_d)/.*.dep $$($(1)_DEPS) $$($(1)_OBJS)
|
||
|
||
# Phony target to run this program (typically as a dependency of 'check').
|
||
.PHONY: $(1)_RUN
|
||
$(1)_RUN: $$($(1)_PATH)
|
||
$(trace-test) $$($(1)_ENV) $$($(1)_PATH)
|
||
|
||
endef
|