mirror of
https://github.com/NixOS/nix.git
synced 2024-11-22 14:52:55 +00:00
c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
17 lines
512 B
Bash
17 lines
512 B
Bash
source common.sh
|
|
|
|
clearStore
|
|
|
|
RESULT=$TEST_ROOT/result
|
|
|
|
nix-build -o $RESULT check-reqs.nix -A test1
|
|
|
|
(! nix-build -o $RESULT check-reqs.nix -A test2)
|
|
(! nix-build -o $RESULT check-reqs.nix -A test3)
|
|
(! nix-build -o $RESULT check-reqs.nix -A test4) 2>&1 | grepQuiet 'check-reqs-dep1'
|
|
(! nix-build -o $RESULT check-reqs.nix -A test4) 2>&1 | grepQuiet 'check-reqs-dep2'
|
|
(! nix-build -o $RESULT check-reqs.nix -A test5)
|
|
(! nix-build -o $RESULT check-reqs.nix -A test6)
|
|
|
|
nix-build -o $RESULT check-reqs.nix -A test7
|