mirror of
https://github.com/NixOS/nix.git
synced 2024-11-26 00:32:28 +00:00
c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
76 lines
2.4 KiB
Bash
76 lines
2.4 KiB
Bash
source common.sh
|
|
|
|
export TEST_VAR=foo # for eval-okay-getenv.nix
|
|
export NIX_REMOTE=dummy://
|
|
export NIX_STORE_DIR=/nix/store
|
|
|
|
nix-instantiate --eval -E 'builtins.trace "Hello" 123' 2>&1 | grepQuiet Hello
|
|
nix-instantiate --eval -E 'builtins.addErrorContext "Hello" 123' 2>&1
|
|
nix-instantiate --trace-verbose --eval -E 'builtins.traceVerbose "Hello" 123' 2>&1 | grepQuiet Hello
|
|
nix-instantiate --eval -E 'builtins.traceVerbose "Hello" 123' 2>&1 | grepQuietInverse Hello
|
|
nix-instantiate --show-trace --eval -E 'builtins.addErrorContext "Hello" 123' 2>&1 | grepQuietInverse Hello
|
|
expectStderr 1 nix-instantiate --show-trace --eval -E 'builtins.addErrorContext "Hello" (throw "Foo")' | grepQuiet Hello
|
|
|
|
set +x
|
|
|
|
fail=0
|
|
|
|
for i in lang/parse-fail-*.nix; do
|
|
echo "parsing $i (should fail)";
|
|
i=$(basename $i .nix)
|
|
if ! expect 1 nix-instantiate --parse - < lang/$i.nix; then
|
|
echo "FAIL: $i shouldn't parse"
|
|
fail=1
|
|
fi
|
|
done
|
|
|
|
for i in lang/parse-okay-*.nix; do
|
|
echo "parsing $i (should succeed)";
|
|
i=$(basename $i .nix)
|
|
if ! expect 0 nix-instantiate --parse - < lang/$i.nix > lang/$i.out; then
|
|
echo "FAIL: $i should parse"
|
|
fail=1
|
|
fi
|
|
done
|
|
|
|
for i in lang/eval-fail-*.nix; do
|
|
echo "evaluating $i (should fail)";
|
|
i=$(basename $i .nix)
|
|
if ! expect 1 nix-instantiate --eval lang/$i.nix; then
|
|
echo "FAIL: $i shouldn't evaluate"
|
|
fail=1
|
|
fi
|
|
done
|
|
|
|
for i in lang/eval-okay-*.nix; do
|
|
echo "evaluating $i (should succeed)";
|
|
i=$(basename $i .nix)
|
|
|
|
if test -e lang/$i.exp; then
|
|
flags=
|
|
if test -e lang/$i.flags; then
|
|
flags=$(cat lang/$i.flags)
|
|
fi
|
|
if ! expect 0 env NIX_PATH=lang/dir3:lang/dir4 HOME=/fake-home nix-instantiate $flags --eval --strict lang/$i.nix > lang/$i.out; then
|
|
echo "FAIL: $i should evaluate"
|
|
fail=1
|
|
elif ! diff <(< lang/$i.out sed -e "s|$(pwd)|/pwd|g") lang/$i.exp; then
|
|
echo "FAIL: evaluation result of $i not as expected"
|
|
fail=1
|
|
fi
|
|
fi
|
|
|
|
if test -e lang/$i.exp.xml; then
|
|
if ! expect 0 nix-instantiate --eval --xml --no-location --strict \
|
|
lang/$i.nix > lang/$i.out.xml; then
|
|
echo "FAIL: $i should evaluate"
|
|
fail=1
|
|
elif ! cmp -s lang/$i.out.xml lang/$i.exp.xml; then
|
|
echo "FAIL: XML evaluation result of $i not as expected"
|
|
fail=1
|
|
fi
|
|
fi
|
|
done
|
|
|
|
exit $fail
|