mirror of
https://github.com/NixOS/nix.git
synced 2024-11-22 23:02:27 +00:00
0f7242ff87
We were bedeviled by sandboxing issues when working on the layered store. The problem ended up being that when we have nested nix builds, and the inner store is inside the build dir (e.g. store is `/build/nix-test/$name/store`, build dir is `/build`) bind mounts clobber each other and store paths cannot be found. After thoroughly cleaning up `local-derivation-goal.cc`, we might be able to make that work. But that is a lot of work. For now, we just fail earlier with a proper error message. Finally, test this: nested sandboxing without the problematic store dir should work, and with should fail with the expected error message. Co-authored-by: Dylan Green <67574902+cidkidnix@users.noreply.github.com> Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
30 lines
932 B
Bash
30 lines
932 B
Bash
export NIX_BIN_DIR=$(dirname $(type -p nix))
|
|
# TODO Get Nix and its closure more flexibly
|
|
export EXTRA_SANDBOX="/nix/store $(dirname $NIX_BIN_DIR)"
|
|
|
|
badStoreUrl () {
|
|
local altitude=$1
|
|
echo $TEST_ROOT/store-$altitude
|
|
}
|
|
|
|
goodStoreUrl () {
|
|
local altitude=$1
|
|
echo $("badStoreUrl" "$altitude")?store=/foo-$altitude
|
|
}
|
|
|
|
# The non-standard sandbox-build-dir helps ensure that we get the same behavior
|
|
# whether this test is being run in a derivation as part of the nix build or
|
|
# being manually run by a developer outside a derivation
|
|
runNixBuild () {
|
|
local storeFun=$1
|
|
local altitude=$2
|
|
nix-build \
|
|
--no-substitute --no-out-link \
|
|
--store "$("$storeFun" "$altitude")" \
|
|
--extra-sandbox-paths "$EXTRA_SANDBOX" \
|
|
./nested-sandboxing/runner.nix \
|
|
--arg altitude "$((altitude - 1))" \
|
|
--argstr storeFun "$storeFun" \
|
|
--sandbox-build-dir /build-non-standard
|
|
}
|