mirror of
https://github.com/NixOS/nix.git
synced 2024-11-29 10:12:28 +00:00
30dcc19d1f
I think it is bad for these reasons when `tests/` contains a mix of
functional and integration tests
- Concepts is harder to understand, the documentation makes a good
unit vs functional vs integration distinction, but when the
integration tests are just two subdirs within `tests/` this is not
clear.
- Source filtering in the `flake.nix` is more complex. We need to
filter out some of the dirs from `tests/`, rather than simply pick
the dirs we want and take all of them. This is a good sign the
structure of what we are trying to do is not matching the structure
of the files.
With this change we have a clean:
```shell-session
$ git show 'HEAD:tests'
tree HEAD:tests
functional/
installer/
nixos/
```
(cherry picked from commit 68c81c7375)
45 lines
1.6 KiB
Bash
45 lines
1.6 KiB
Bash
source common.sh
|
||
|
||
clearStore
|
||
|
||
cd "$TEST_HOME"
|
||
|
||
cat <<EOF > flake.nix
|
||
{
|
||
outputs = a: {
|
||
packages.$system = {
|
||
foo = 1;
|
||
fo1 = 1;
|
||
fo2 = 1;
|
||
fooo = 1;
|
||
foooo = 1;
|
||
fooooo = 1;
|
||
fooooo1 = 1;
|
||
fooooo2 = 1;
|
||
fooooo3 = 1;
|
||
fooooo4 = 1;
|
||
fooooo5 = 1;
|
||
fooooo6 = 1;
|
||
};
|
||
};
|
||
}
|
||
EOF
|
||
|
||
# Probable typo in the requested attribute path. Suggest some close possibilities
|
||
NIX_BUILD_STDERR_WITH_SUGGESTIONS=$(! nix build .\#fob 2>&1 1>/dev/null)
|
||
[[ "$NIX_BUILD_STDERR_WITH_SUGGESTIONS" =~ "Did you mean one of fo1, fo2, foo or fooo?" ]] || \
|
||
fail "The nix build stderr should suggest the three closest possiblities"
|
||
|
||
# None of the possible attributes is close to `bar`, so shouldn’t suggest anything
|
||
NIX_BUILD_STDERR_WITH_NO_CLOSE_SUGGESTION=$(! nix build .\#bar 2>&1 1>/dev/null)
|
||
[[ ! "$NIX_BUILD_STDERR_WITH_NO_CLOSE_SUGGESTION" =~ "Did you mean" ]] || \
|
||
fail "The nix build stderr shouldn’t suggest anything if there’s nothing relevant to suggest"
|
||
|
||
NIX_EVAL_STDERR_WITH_SUGGESTIONS=$(! nix build --impure --expr '(builtins.getFlake (builtins.toPath ./.)).packages.'$system'.fob' 2>&1 1>/dev/null)
|
||
[[ "$NIX_EVAL_STDERR_WITH_SUGGESTIONS" =~ "Did you mean one of fo1, fo2, foo or fooo?" ]] || \
|
||
fail "The evaluator should suggest the three closest possiblities"
|
||
|
||
NIX_EVAL_STDERR_WITH_SUGGESTIONS=$(! nix build --impure --expr '({ foo }: foo) { foo = 1; fob = 2; }' 2>&1 1>/dev/null)
|
||
[[ "$NIX_EVAL_STDERR_WITH_SUGGESTIONS" =~ "Did you mean foo?" ]] || \
|
||
fail "The evaluator should suggest the three closest possiblities"
|