mirror of
https://github.com/NixOS/nix.git
synced 2024-11-26 16:52:27 +00:00
4993174be5
The link failure happens on a system with stable nix-2.3.15
installed in /usr/lib64 (it's libutil.so API differs from master):
```
LANG=C make V=1
g++ -o /home/slyfox/dev/git/nix/src/libstore/libnixstore.so \
-shared -L/usr/lib64 -Wl,--no-copy-dt-needed-entries \
src/libstore/binary-cache-store.o ... src/libstore/uds-remote-store.o \
-lsqlite3 -lcurl -lsodium -pthread -ldl -lseccomp -Wl,-z,defs -Wl,-soname=libnixstore.so
-Wl,-rpath,/home/slyfox/dev/git/nix/src/libutil -Lsrc/libutil -lnixutil
ld: src/libstore/binary-cache-store.o: in function `nix::BinaryCacheStore::BinaryCacheStore(
std::map<std::__cxx11::basic_string<char, std::char_traits<char>, ...
nix/src/libstore/binary-cache-store.cc:30: undefined reference to `nix::readFile(
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' ...
...
```
This happens due to `-L/usr/lib64 -Lsrc/libutil` search path ordering.
The change turns it into `-Lsrc/libutil -L/usr/lib64`.
Closes: https://github.com/NixOS/nix/issues/3087
89 lines
3.1 KiB
Makefile
89 lines
3.1 KiB
Makefile
programs-list :=
|
||
|
||
# Build a program with symbolic name $(1). The program is defined by
|
||
# various variables prefixed by ‘$(1)_’:
|
||
#
|
||
# - $(1)_DIR: the directory where the (non-installed) program will be
|
||
# placed.
|
||
#
|
||
# - $(1)_SOURCES: the source files of the program.
|
||
#
|
||
# - $(1)_CFLAGS: additional C compiler flags.
|
||
#
|
||
# - $(1)_CXXFLAGS: additional C++ compiler flags.
|
||
#
|
||
# - $(1)_ORDER_AFTER: a set of targets on which the object files of
|
||
# this program will have an order-only dependency.
|
||
#
|
||
# - $(1)_LIBS: the symbolic names of libraries on which this program
|
||
# depends.
|
||
#
|
||
# - $(1)_LDFLAGS: additional linker flags.
|
||
#
|
||
# - $(1)_INSTALL_DIR: the directory where the program will be
|
||
# installed; defaults to $(bindir).
|
||
define build-program
|
||
_d := $(buildprefix)$$($(1)_DIR)
|
||
_srcs := $$(sort $$(foreach src, $$($(1)_SOURCES), $$(src)))
|
||
$(1)_OBJS := $$(addprefix $(buildprefix), $$(addsuffix .o, $$(basename $$(_srcs))))
|
||
_libs := $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_PATH))
|
||
$(1)_PATH := $$(_d)/$(1)
|
||
|
||
$$(eval $$(call create-dir, $$(_d)))
|
||
|
||
$$($(1)_PATH): $$($(1)_OBJS) $$(_libs) | $$(_d)/
|
||
$$(trace-ld) $(CXX) -o $$@ $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_LDFLAGS_USE)) $$(LDFLAGS) $$(GLOBAL_LDFLAGS) $$($(1)_OBJS) $$($(1)_LDFLAGS)
|
||
|
||
$(1)_INSTALL_DIR ?= $$(bindir)
|
||
|
||
ifdef $(1)_INSTALL_DIR
|
||
|
||
$(1)_INSTALL_PATH := $$($(1)_INSTALL_DIR)/$(1)
|
||
|
||
$$(eval $$(call create-dir, $$($(1)_INSTALL_DIR)))
|
||
|
||
install: $(DESTDIR)$$($(1)_INSTALL_PATH)
|
||
|
||
ifeq ($(BUILD_SHARED_LIBS), 1)
|
||
|
||
_libs_final := $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_INSTALL_PATH))
|
||
|
||
$(DESTDIR)$$($(1)_INSTALL_PATH): $$($(1)_OBJS) $$(_libs_final) | $(DESTDIR)$$($(1)_INSTALL_DIR)/
|
||
$$(trace-ld) $(CXX) -o $$@ $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_LDFLAGS_USE_INSTALLED)) $$(LDFLAGS) $$(GLOBAL_LDFLAGS) $$($(1)_OBJS) $$($(1)_LDFLAGS)
|
||
|
||
else
|
||
|
||
$(DESTDIR)$$($(1)_INSTALL_PATH): $$($(1)_PATH) | $(DESTDIR)$$($(1)_INSTALL_DIR)/
|
||
install -t $(DESTDIR)$$($(1)_INSTALL_DIR) $$<
|
||
|
||
endif
|
||
endif
|
||
|
||
# Propagate CFLAGS and CXXFLAGS to the individual object files.
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj)_CFLAGS=$$($(1)_CFLAGS)))
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj)_CXXFLAGS=$$($(1)_CXXFLAGS)))
|
||
|
||
# Make each object file depend on the common dependencies.
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj): $$($(1)_COMMON_DEPS) $$(GLOBAL_COMMON_DEPS)))
|
||
|
||
# Make each object file have order-only dependencies on the common
|
||
# order-only dependencies. This includes the order-only dependencies
|
||
# of libraries we're depending on.
|
||
$(1)_ORDER_AFTER_CLOSED = $$($(1)_ORDER_AFTER) $$(foreach lib, $$($(1)_LIBS), $$($$(lib)_ORDER_AFTER_CLOSED))
|
||
|
||
$$(foreach obj, $$($(1)_OBJS), $$(eval $$(obj): | $$($(1)_ORDER_AFTER_CLOSED) $$(GLOBAL_ORDER_AFTER)))
|
||
|
||
# Include .dep files, if they exist.
|
||
$(1)_DEPS := $$(foreach fn, $$($(1)_OBJS), $$(call filename-to-dep, $$(fn)))
|
||
-include $$($(1)_DEPS)
|
||
|
||
programs-list += $$($(1)_PATH)
|
||
clean-files += $$($(1)_PATH) $$(_d)/*.o $$(_d)/.*.dep $$($(1)_DEPS) $$($(1)_OBJS)
|
||
|
||
# Phony target to run this program (typically as a dependency of 'check').
|
||
.PHONY: $(1)_RUN
|
||
$(1)_RUN: $$($(1)_PATH)
|
||
$(trace-test) $$($(1)_PATH)
|
||
|
||
endef
|