mirror of
https://github.com/NixOS/nix.git
synced 2024-11-25 16:23:02 +00:00
30dcc19d1f
I think it is bad for these reasons when `tests/` contains a mix of
functional and integration tests
- Concepts is harder to understand, the documentation makes a good
unit vs functional vs integration distinction, but when the
integration tests are just two subdirs within `tests/` this is not
clear.
- Source filtering in the `flake.nix` is more complex. We need to
filter out some of the dirs from `tests/`, rather than simply pick
the dirs we want and take all of them. This is a good sign the
structure of what we are trying to do is not matching the structure
of the files.
With this change we have a clean:
```shell-session
$ git show 'HEAD:tests'
tree HEAD:tests
functional/
installer/
nixos/
```
(cherry picked from commit 68c81c7375)
58 lines
1.4 KiB
Nix
58 lines
1.4 KiB
Nix
with import ./config.nix;
|
|
|
|
rec {
|
|
dep1 = mkDerivation {
|
|
name = "check-reqs-dep1";
|
|
builder = builtins.toFile "builder.sh" "mkdir $out; touch $out/file1";
|
|
};
|
|
|
|
dep2 = mkDerivation {
|
|
name = "check-reqs-dep2";
|
|
builder = builtins.toFile "builder.sh" "mkdir $out; touch $out/file2";
|
|
};
|
|
|
|
deps = mkDerivation {
|
|
name = "check-reqs-deps";
|
|
dep1 = dep1;
|
|
dep2 = dep2;
|
|
builder = builtins.toFile "builder.sh" ''
|
|
mkdir $out
|
|
ln -s $dep1/file1 $out/file1
|
|
ln -s $dep2/file2 $out/file2
|
|
'';
|
|
};
|
|
|
|
makeTest = nr: allowreqs: mkDerivation {
|
|
name = "check-reqs-" + toString nr;
|
|
inherit deps;
|
|
builder = builtins.toFile "builder.sh" ''
|
|
mkdir $out
|
|
ln -s $deps $out/depdir1
|
|
'';
|
|
allowedRequisites = allowreqs;
|
|
};
|
|
|
|
# When specifying all the requisites, the build succeeds.
|
|
test1 = makeTest 1 [ dep1 dep2 deps ];
|
|
|
|
# But missing anything it fails.
|
|
test2 = makeTest 2 [ dep2 deps ];
|
|
test3 = makeTest 3 [ dep1 deps ];
|
|
test4 = makeTest 4 [ deps ];
|
|
test5 = makeTest 5 [];
|
|
|
|
test6 = mkDerivation {
|
|
name = "check-reqs";
|
|
inherit deps;
|
|
builder = builtins.toFile "builder.sh" "mkdir $out; ln -s $deps $out/depdir1";
|
|
disallowedRequisites = [dep1];
|
|
};
|
|
|
|
test7 = mkDerivation {
|
|
name = "check-reqs";
|
|
inherit deps;
|
|
builder = builtins.toFile "builder.sh" "mkdir $out; ln -s $deps $out/depdir1";
|
|
disallowedRequisites = [test1];
|
|
};
|
|
}
|