mirror of
https://github.com/NixOS/nix.git
synced 2024-11-22 06:42:28 +00:00
c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
68 lines
1.7 KiB
Bash
68 lines
1.7 KiB
Bash
source common.sh
|
|
|
|
###################################################
|
|
# Check that --dry-run isn't confused with read-only mode
|
|
# https://github.com/NixOS/nix/issues/1795
|
|
|
|
clearStore
|
|
clearCache
|
|
|
|
# Ensure this builds successfully first
|
|
nix build --no-link -f dependencies.nix
|
|
|
|
clearStore
|
|
clearCache
|
|
|
|
# Try --dry-run using old command first
|
|
nix-build --no-out-link dependencies.nix --dry-run 2>&1 | grep "will be built"
|
|
# Now new command:
|
|
nix build -f dependencies.nix --dry-run 2>&1 | grep "will be built"
|
|
|
|
clearStore
|
|
clearCache
|
|
|
|
# Try --dry-run using new command first
|
|
nix build -f dependencies.nix --dry-run 2>&1 | grep "will be built"
|
|
# Now old command:
|
|
nix-build --no-out-link dependencies.nix --dry-run 2>&1 | grep "will be built"
|
|
|
|
###################################################
|
|
# Check --dry-run doesn't create links with --dry-run
|
|
# https://github.com/NixOS/nix/issues/1849
|
|
clearStore
|
|
clearCache
|
|
|
|
RESULT=$TEST_ROOT/result-link
|
|
rm -f $RESULT
|
|
|
|
nix-build dependencies.nix -o $RESULT --dry-run
|
|
|
|
[[ ! -h $RESULT ]] || fail "nix-build --dry-run created output link"
|
|
|
|
nix build -f dependencies.nix -o $RESULT --dry-run
|
|
|
|
[[ ! -h $RESULT ]] || fail "nix build --dry-run created output link"
|
|
|
|
nix build -f dependencies.nix -o $RESULT
|
|
|
|
[[ -h $RESULT ]]
|
|
|
|
###################################################
|
|
# Check the JSON output
|
|
clearStore
|
|
clearCache
|
|
|
|
RES=$(nix build -f dependencies.nix --dry-run --json)
|
|
|
|
if [[ -z "${NIX_TESTS_CA_BY_DEFAULT-}" ]]; then
|
|
echo "$RES" | jq '.[0] | [
|
|
(.drvPath | test("'$NIX_STORE_DIR'.*\\.drv")),
|
|
(.outputs.out | test("'$NIX_STORE_DIR'"))
|
|
] | all'
|
|
else
|
|
echo "$RES" | jq '.[0] | [
|
|
(.drvPath | test("'$NIX_STORE_DIR'.*\\.drv")),
|
|
.outputs.out == null
|
|
] | all'
|
|
fi
|