chore: run formatters

This commit is contained in:
Bryan Honof 2024-09-19 19:15:31 +02:00
parent affd2dbc6c
commit c800f3fa93
No known key found for this signature in database
3 changed files with 57 additions and 60 deletions

View File

@ -28,8 +28,6 @@
''^src/build-remote/build-remote\.cc$'' ''^src/build-remote/build-remote\.cc$''
''^src/libcmd/built-path\.cc$'' ''^src/libcmd/built-path\.cc$''
''^src/libcmd/built-path\.hh$'' ''^src/libcmd/built-path\.hh$''
''^src/libcmd/command\.cc$''
''^src/libcmd/command\.hh$''
''^src/libcmd/common-eval-args\.cc$'' ''^src/libcmd/common-eval-args\.cc$''
''^src/libcmd/common-eval-args\.hh$'' ''^src/libcmd/common-eval-args\.hh$''
''^src/libcmd/editor-for\.cc$'' ''^src/libcmd/editor-for\.cc$''

View File

@ -23,7 +23,8 @@ nix::Commands RegisterCommand::getCommandsFor(const std::vector<std::string> & p
if (name.size() == prefix.size() + 1) { if (name.size() == prefix.size() + 1) {
bool equal = true; bool equal = true;
for (size_t i = 0; i < prefix.size(); ++i) for (size_t i = 0; i < prefix.size(); ++i)
if (name[i] != prefix[i]) equal = false; if (name[i] != prefix[i])
equal = false;
if (equal) if (equal)
res.insert_or_assign(name[prefix.size()], command); res.insert_or_assign(name[prefix.size()], command);
} }
@ -42,16 +43,16 @@ void NixMultiCommand::run()
std::set<std::string> subCommandTextLines; std::set<std::string> subCommandTextLines;
for (auto & [name, _] : commands) for (auto & [name, _] : commands)
subCommandTextLines.insert(fmt("- `%s`", name)); subCommandTextLines.insert(fmt("- `%s`", name));
std::string markdownError = fmt("`nix %s` requires a sub-command. Available sub-commands:\n\n%s\n", std::string markdownError =
commandName, concatStringsSep("\n", subCommandTextLines)); fmt("`nix %s` requires a sub-command. Available sub-commands:\n\n%s\n",
commandName,
concatStringsSep("\n", subCommandTextLines));
throw UsageError(renderMarkdownToTerminal(markdownError)); throw UsageError(renderMarkdownToTerminal(markdownError));
} }
command->second->run(); command->second->run();
} }
StoreCommand::StoreCommand() StoreCommand::StoreCommand() {}
{
}
ref<Store> StoreCommand::getStore() ref<Store> StoreCommand::getStore()
{ {
@ -126,10 +127,8 @@ ref<Store> EvalCommand::getEvalStore()
ref<EvalState> EvalCommand::getEvalState() ref<EvalState> EvalCommand::getEvalState()
{ {
if (!evalState) { if (!evalState) {
evalState = evalState = std::allocate_shared<EvalState>(
std::allocate_shared<EvalState>( traceable_allocator<EvalState>(), lookupPath, getEvalStore(), fetchSettings, evalSettings, getStore());
traceable_allocator<EvalState>(),
lookupPath, getEvalStore(), fetchSettings, evalSettings, getStore());
evalState->repair = repair; evalState->repair = repair;
@ -144,7 +143,8 @@ MixOperateOnOptions::MixOperateOnOptions()
{ {
addFlag({ addFlag({
.longName = "derivation", .longName = "derivation",
.description = "Operate on the [store derivation](@docroot@/glossary.md#gloss-store-derivation) rather than its outputs.", .description =
"Operate on the [store derivation](@docroot@/glossary.md#gloss-store-derivation) rather than its outputs.",
.category = installablesCategory, .category = installablesCategory,
.handler = {&operateOn, OperateOn::Derivation}, .handler = {&operateOn, OperateOn::Derivation},
}); });
@ -233,46 +233,48 @@ void StorePathCommand::run(ref<Store> store, StorePaths && storePaths)
MixProfile::MixProfile() MixProfile::MixProfile()
{ {
addFlag({ addFlag(
.longName = "profile", {.longName = "profile",
.description = "The profile to operate on.", .description = "The profile to operate on.",
.labels = {"path"}, .labels = {"path"},
.handler = {&profile}, .handler = {&profile},
.completer = completePath .completer = completePath});
});
} }
void MixProfile::updateProfile(const StorePath & storePath) void MixProfile::updateProfile(const StorePath & storePath)
{ {
if (!profile) return; if (!profile)
return;
auto store = getStore().dynamic_pointer_cast<LocalFSStore>(); auto store = getStore().dynamic_pointer_cast<LocalFSStore>();
if (!store) throw Error("'--profile' is not supported for this Nix store"); if (!store)
throw Error("'--profile' is not supported for this Nix store");
auto profile2 = absPath(*profile); auto profile2 = absPath(*profile);
switchLink(profile2, switchLink(profile2, createGeneration(*store, profile2, storePath));
createGeneration(*store, profile2, storePath));
} }
void MixProfile::updateProfile(const BuiltPaths & buildables) void MixProfile::updateProfile(const BuiltPaths & buildables)
{ {
if (!profile) return; if (!profile)
return;
StorePaths result; StorePaths result;
for (auto & buildable : buildables) { for (auto & buildable : buildables) {
std::visit(overloaded { std::visit(
[&](const BuiltPath::Opaque & bo) { overloaded{
result.push_back(bo.path); [&](const BuiltPath::Opaque & bo) { result.push_back(bo.path); },
},
[&](const BuiltPath::Built & bfd) { [&](const BuiltPath::Built & bfd) {
for (auto & output : bfd.outputs) { for (auto & output : bfd.outputs) {
result.push_back(output.second); result.push_back(output.second);
} }
}, },
}, buildable.raw()); },
buildable.raw());
} }
if (result.size() != 1) if (result.size() != 1)
throw UsageError("'--profile' requires that the arguments produce a single store path, but there are %d", result.size()); throw UsageError(
"'--profile' requires that the arguments produce a single store path, but there are %d", result.size());
updateProfile(result[0]); updateProfile(result[0]);
} }
@ -282,7 +284,8 @@ MixDefaultProfile::MixDefaultProfile()
profile = getDefaultProfile(); profile = getDefaultProfile();
} }
MixEnvironment::MixEnvironment() : ignoreEnvironment(false) MixEnvironment::MixEnvironment()
: ignoreEnvironment(false)
{ {
addFlag({ addFlag({
.longName = "ignore-env", .longName = "ignore-env",
@ -338,7 +341,8 @@ MixEnvironment::MixEnvironment() : ignoreEnvironment(false)
}); });
} }
void MixEnvironment::setEnviron() { void MixEnvironment::setEnviron()
{
if (ignoreEnvironment && !unsetVars.empty()) if (ignoreEnvironment && !unsetVars.empty())
throw UsageError("--unset-env-var does not make sense with --ignore-env"); throw UsageError("--unset-env-var does not make sense with --ignore-env");
@ -348,17 +352,13 @@ void MixEnvironment::setEnviron() {
auto env = getEnv(); auto env = getEnv();
if (ignoreEnvironment) if (ignoreEnvironment)
std::erase_if(env, [&](const auto & var) { std::erase_if(env, [&](const auto & var) { return !keepVars.contains(var.first); });
return !keepVars.contains(var.first);
});
for (const auto & [name, value] : setVars) for (const auto & [name, value] : setVars)
env[name] = value; env[name] = value;
if (!unsetVars.empty()) if (!unsetVars.empty())
std::erase_if(env, [&](const auto & var) { std::erase_if(env, [&](const auto & var) { return unsetVars.contains(var.first); });
return unsetVars.contains(var.first);
});
replaceEnv(env); replaceEnv(env);

View File

@ -24,7 +24,8 @@ static constexpr Command::Category catSecondary = 100;
static constexpr Command::Category catUtility = 101; static constexpr Command::Category catUtility = 101;
static constexpr Command::Category catNixInstallation = 102; static constexpr Command::Category catNixInstallation = 102;
static constexpr auto installablesCategory = "Options that change the interpretation of [installables](@docroot@/command-ref/new-cli/nix.md#installables)"; static constexpr auto installablesCategory =
"Options that change the interpretation of [installables](@docroot@/command-ref/new-cli/nix.md#installables)";
struct NixMultiCommand : MultiCommand, virtual Command struct NixMultiCommand : MultiCommand, virtual Command
{ {
@ -112,7 +113,9 @@ struct MixFlakeOptions : virtual Args, EvalCommand
* arguments) so that the completions for these flags can use them. * arguments) so that the completions for these flags can use them.
*/ */
virtual std::vector<FlakeRef> getFlakeRefsForCompletion() virtual std::vector<FlakeRef> getFlakeRefsForCompletion()
{ return {}; } {
return {};
}
}; };
struct SourceExprCommand : virtual Args, MixFlakeOptions struct SourceExprCommand : virtual Args, MixFlakeOptions
@ -122,11 +125,9 @@ struct SourceExprCommand : virtual Args, MixFlakeOptions
SourceExprCommand(); SourceExprCommand();
Installables parseInstallables( Installables parseInstallables(ref<Store> store, std::vector<std::string> ss);
ref<Store> store, std::vector<std::string> ss);
ref<Installable> parseInstallable( ref<Installable> parseInstallable(ref<Store> store, const std::string & installable);
ref<Store> store, const std::string & installable);
virtual Strings getDefaultFlakeAttrPaths(); virtual Strings getDefaultFlakeAttrPaths();
@ -272,10 +273,10 @@ struct RegisterCommand
typedef std::map<std::vector<std::string>, std::function<ref<Command>()>> Commands; typedef std::map<std::vector<std::string>, std::function<ref<Command>()>> Commands;
static Commands * commands; static Commands * commands;
RegisterCommand(std::vector<std::string> && name, RegisterCommand(std::vector<std::string> && name, std::function<ref<Command>()> command)
std::function<ref<Command>()> command)
{ {
if (!commands) commands = new Commands; if (!commands)
commands = new Commands;
commands->emplace(name, command); commands->emplace(name, command);
} }
@ -313,7 +314,8 @@ struct MixDefaultProfile : MixProfile
MixDefaultProfile(); MixDefaultProfile();
}; };
struct MixEnvironment : virtual Args { struct MixEnvironment : virtual Args
{
StringSet keepVars; StringSet keepVars;
StringSet unsetVars; StringSet unsetVars;
@ -350,9 +352,6 @@ void completeFlakeRefWithFragment(
std::string showVersions(const std::set<std::string> & versions); std::string showVersions(const std::set<std::string> & versions);
void printClosureDiff( void printClosureDiff(
ref<Store> store, ref<Store> store, const StorePath & beforePath, const StorePath & afterPath, std::string_view indent);
const StorePath & beforePath,
const StorePath & afterPath,
std::string_view indent);
} }