Merge pull request #11718 from xokdvium/dev/move-create-directory-out-of-assert

fix(nix/eval.cc): move call to `fs::create_directory` out of `assert`
2024-11-25 08:12:29 +00:00 · 2024-10-21 14:22:40 +02:00 · 2024-10-21 14:22:40 +02:00 · b93b910fec
commit b93b910fec
parent 694c378d14 8277b50b6f
1 changed files with 2 additions and 1 deletions
--- a/src/nix/eval.cc
+++ b/src/nix/eval.cc
@ -89,8 +89,9 @@ struct CmdEval : MixJSON, InstallableValueCommand, MixReadOnlyOption
                    // FIXME: disallow strings with contexts?
                    writeFile(path.string(), v.string_view());
                else if (v.type() == nAttrs) {
+                    [[maybe_unused]] bool directoryCreated = fs::create_directory(path);
                    // Directory should not already exist
-                    assert(fs::create_directory(path.string()));
+                    assert(directoryCreated);
                    for (auto & attr : *v.attrs()) {
                        std::string_view name = state->symbols[attr.name];
                        try {