From 58428a40692616191edf6bdea2ba0858e9c4d2fa Mon Sep 17 00:00:00 2001
From: Marian Hammer <marian.hammer@meetwise.com>
Date: Fri, 18 Oct 2024 11:06:41 +0200
Subject: [PATCH] nix/tests: run test help.sh only if nix is built with
 documentation

tests/functional/help.sh calls nix-* commands with option --help
if nix is built without documentation the option --help throws an error
because the man page it wants to display is missing

(cherry picked from commit 85b0cd320a1d3cdb9bcbfa650f7080839ab2fc55)
---
 configure.ac              | 4 ++++
 package.nix               | 3 ++-
 tests/functional/local.mk | 5 ++++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 5c22ed176..d51f1f39e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -170,6 +170,10 @@ AS_IF(
   [test "$ENABLE_FUNCTIONAL_TESTS" == "yes" || test "$ENABLE_DOC_GEN" == "yes"],
   [NEED_PROG(jq, jq)])
 
+AS_IF(
+  [test "$ENABLE_DOC_GEN" == "yes"],
+  [NEED_PROG(man, man)])
+
 AS_IF([test "$ENABLE_BUILD" == "yes"],[
 
 # Look for boost, a required dependency.
diff --git a/package.nix b/package.nix
index a7c8923e8..15eac4f12 100644
--- a/package.nix
+++ b/package.nix
@@ -210,9 +210,10 @@ in {
     git
     mercurial
     openssh
-    man # for testing `nix-* --help`
   ] ++ lib.optionals (doInstallCheck || enableManual) [
     jq # Also for custom mdBook preprocessor.
+  ] ++ lib.optionals enableManual [
+    man
   ] ++ lib.optional stdenv.hostPlatform.isStatic unixtools.hexdump
   ;
 
diff --git a/tests/functional/local.mk b/tests/functional/local.mk
index f61823765..a0d1eafe8 100644
--- a/tests/functional/local.mk
+++ b/tests/functional/local.mk
@@ -114,7 +114,6 @@ nix_tests = \
   impure-env.sh \
   debugger.sh \
   extra-sandbox-profile.sh \
-  help.sh
 
 ifeq ($(HAVE_LIBCPUID), 1)
   nix_tests += compute-levels.sh
@@ -128,6 +127,10 @@ ifeq ($(ENABLE_BUILD), yes)
   endif
 endif
 
+ifeq ($(ENABLE_DOC_GEN), yes)
+    nix_tests += help.sh
+endif
+
 $(d)/test-libstoreconsumer.sh.test $(d)/test-libstoreconsumer.sh.test-debug: \
   $(buildprefix)$(d)/test-libstoreconsumer/test-libstoreconsumer
 $(d)/plugins.sh.test $(d)/plugins.sh.test-debug: \