Remove global -I flags

2024-10-29 21:30:51 +00:00 · 2020-03-30 14:29:29 +02:00 · 2020-03-30 14:29:29 +02:00 · 2c692a3b14
commit 2c692a3b14
parent e0a0ae0467
20 changed files with 30 additions and 17 deletions
--- a/local.mk
+++ b/local.mk
@ -6,9 +6,11 @@ dist-files += configure config.h.in perl/configure

 clean-files += Makefile.config

-GLOBAL_CXXFLAGS += -I . -I src -I src/libutil -I src/libstore -I src/libfetchers -I src/libmain -I src/libexpr -I src/nix -Wno-deprecated-declarations
+GLOBAL_CXXFLAGS += -Wno-deprecated-declarations

 $(foreach i, config.h $(wildcard src/lib*/*.hh), \
  $(eval $(call install-file-in, $(i), $(includedir)/nix, 0644)))

 $(GCH) $(PCH): src/libutil/util.hh config.h
+
+GCH_CXXFLAGS = -I src/libutil
--- a/mk/precompiled-headers.mk
+++ b/mk/precompiled-headers.mk
@ -8,14 +8,14 @@ GCH = $(buildprefix)precompiled-headers.h.gch
 $(GCH): precompiled-headers.h
 	@rm -f $@
 	@mkdir -p "$(dir $@)"
-	$(trace-gen) $(CXX) -x c++-header -o $@ $< $(GLOBAL_CXXFLAGS)
+	$(trace-gen) $(CXX) -x c++-header -o $@ $< $(GLOBAL_CXXFLAGS) $(GCH_CXXFLAGS)

 PCH = $(buildprefix)precompiled-headers.h.pch

 $(PCH): precompiled-headers.h
 	@rm -f $@
 	@mkdir -p "$(dir $@)"
-	$(trace-gen) $(CXX) -x c++-header -o $@ $< $(GLOBAL_CXXFLAGS)
+	$(trace-gen) $(CXX) -x c++-header -o $@ $< $(GLOBAL_CXXFLAGS) $(GCH_CXXFLAGS)

 clean-files += $(GCH) $(PCH)

--- a/src/build-remote/build-remote.cc
+++ b/src/build-remote/build-remote.cc
@ -17,7 +17,7 @@
 #include "store-api.hh"
 #include "derivations.hh"
 #include "local-store.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 using namespace nix;
 using std::cin;
--- a/src/libexpr/local.mk
+++ b/src/libexpr/local.mk
@ -11,6 +11,8 @@ libexpr_SOURCES := \
  $(d)/lexer-tab.cc \
  $(d)/parser-tab.cc

+libexpr_CXXFLAGS += -I src/libutil -I src/libstore -I src/libfetchers -I src/libmain -I src/libexpr
+
 libexpr_LIBS = libutil libstore libfetchers libnixrust

 libexpr_LDFLAGS =
--- a/src/libexpr/primops/fromTOML.cc
+++ b/src/libexpr/primops/fromTOML.cc
@ -1,7 +1,7 @@
 #include "primops.hh"
 #include "eval-inline.hh"

-#include "cpptoml/cpptoml.h"
+#include "../../cpptoml/cpptoml.h"

 namespace nix {

--- a/src/libfetchers/local.mk
+++ b/src/libfetchers/local.mk
@ -6,4 +6,6 @@ libfetchers_DIR := $(d)

 libfetchers_SOURCES := $(wildcard $(d)/*.cc)

+libfetchers_CXXFLAGS += -I src/libutil -I src/libstore
+
 libfetchers_LIBS = libutil libstore libnixrust
--- a/src/libmain/local.mk
+++ b/src/libmain/local.mk
@ -6,6 +6,8 @@ libmain_DIR := $(d)

 libmain_SOURCES := $(wildcard $(d)/*.cc)

+libmain_CXXFLAGS += -I src/libutil -I src/libstore
+
 libmain_LDFLAGS = $(OPENSSL_LIBS)

 libmain_LIBS = libstore libutil
--- a/src/libstore/local.mk
+++ b/src/libstore/local.mk
@ -31,7 +31,8 @@ ifeq ($(HAVE_SECCOMP), 1)
 	libstore_LDFLAGS += -lseccomp
 endif

-libstore_CXXFLAGS = \
+libstore_CXXFLAGS += \
+ -I src/libutil -I src/libstore \
 -DNIX_PREFIX=\"$(prefix)\" \
 -DNIX_STORE_DIR=\"$(storedir)\" \
 -DNIX_DATA_DIR=\"$(datadir)\" \
--- a/src/nix-build/nix-build.cc
+++ b/src/nix-build/nix-build.cc
@ -16,7 +16,7 @@
 #include "get-drvs.hh"
 #include "common-eval-args.hh"
 #include "attr-path.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 using namespace nix;
 using namespace std::string_literals;
--- a/src/nix-channel/nix-channel.cc
+++ b/src/nix-channel/nix-channel.cc
@ -2,7 +2,7 @@
 #include "globals.hh"
 #include "download.hh"
 #include "store-api.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"
 #include "fetchers.hh"

 #include <fcntl.h>
--- a/src/nix-collect-garbage/nix-collect-garbage.cc
+++ b/src/nix-collect-garbage/nix-collect-garbage.cc
@ -2,7 +2,7 @@
 #include "profiles.hh"
 #include "shared.hh"
 #include "globals.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 #include <iostream>
 #include <cerrno>
--- a/src/nix-copy-closure/nix-copy-closure.cc
+++ b/src/nix-copy-closure/nix-copy-closure.cc
@ -1,6 +1,6 @@
 #include "shared.hh"
 #include "store-api.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 using namespace nix;

--- a/src/nix-daemon/nix-daemon.cc
+++ b/src/nix-daemon/nix-daemon.cc
@ -6,7 +6,7 @@
 #include "globals.hh"
 #include "derivations.hh"
 #include "finally.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"
 #include "daemon.hh"

 #include <algorithm>
--- a/src/nix-env/nix-env.cc
+++ b/src/nix-env/nix-env.cc
@ -13,7 +13,7 @@
 #include "json.hh"
 #include "value-to-json.hh"
 #include "xml-writer.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 #include <cerrno>
 #include <ctime>
--- a/src/nix-instantiate/nix-instantiate.cc
+++ b/src/nix-instantiate/nix-instantiate.cc
@ -9,7 +9,7 @@
 #include "util.hh"
 #include "store-api.hh"
 #include "common-eval-args.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 #include <map>
 #include <iostream>
--- a/src/nix-prefetch-url/nix-prefetch-url.cc
+++ b/src/nix-prefetch-url/nix-prefetch-url.cc
@ -6,9 +6,9 @@
 #include "eval-inline.hh"
 #include "common-eval-args.hh"
 #include "attr-path.hh"
-#include "legacy.hh"
 #include "finally.hh"
-#include "progress-bar.hh"
+#include "../nix/legacy.hh"
+#include "../nix/progress-bar.hh"
 #include "tarfile.hh"

 #include <iostream>
--- a/src/nix-store/nix-store.cc
+++ b/src/nix-store/nix-store.cc
@ -9,7 +9,7 @@
 #include "util.hh"
 #include "worker-protocol.hh"
 #include "graphml.hh"
-#include "legacy.hh"
+#include "../nix/legacy.hh"

 #include <iostream>
 #include <algorithm>
--- a/src/nix/local.mk
+++ b/src/nix/local.mk
@ -15,6 +15,8 @@ nix_SOURCES := \
  $(wildcard src/nix-prefetch-url/*.cc) \
  $(wildcard src/nix-store/*.cc) \

+nix_CXXFLAGS += -I src/libutil -I src/libstore -I src/libfetchers -I src/libexpr -I src/libmain
+
 nix_LIBS = libexpr libmain libfetchers libstore libutil libnixrust

 nix_LDFLAGS = -pthread $(SODIUM_LIBS) $(EDITLINE_LIBS) $(BOOST_LDFLAGS) -lboost_context -lboost_thread -lboost_system
--- a/src/nix/profile.cc
+++ b/src/nix/profile.cc
@ -6,7 +6,7 @@
 #include "archive.hh"
 #include "builtins/buildenv.hh"
 #include "flake/flakeref.hh"
-#include "nix-env/user-env.hh"
+#include "../nix-env/user-env.hh"

 #include <nlohmann/json.hpp>
 #include <regex>
--- a/tests/plugins/local.mk
+++ b/tests/plugins/local.mk
@ -7,3 +7,5 @@ libplugintest_SOURCES := $(d)/plugintest.cc
 libplugintest_ALLOW_UNDEFINED := 1

 libplugintest_EXCLUDE_FROM_LIBRARY_LIST := 1
+
+libplugintest_CXXFLAGS := -I src/libutil -I src/libexpr