nordic-dev.net/nix - nix - nordic-dev.net

mirror of https://github.com/NixOS/nix.git synced 2024-11-25 16:23:02 +00:00

libexpr: Recognize newline in more places in lexer Flex's regexes have an annoying feature: the dot matches everything except a newline. This causes problems for expressions like: "${0}\ " where the backslash-newline combination matches this rule instead of the intended one mentioned in the comment: <STRING>\$\|\\\|\$\\ { /* This can only occur when we reach EOF, otherwise the above (...\|\$[^\{\"\\]\|\\.\|\$\\.)+ would have triggered. This is technically invalid, but we leave the problem to the parser who fails with exact location. */ return STR; } However, the parser actually accepts the resulting token sequence ('"' DOLLAR_CURLY 0 '}' STR '"'), which is a problem because the lexer rule didn't assign anything to yylval. Ultimately this leads to a crash when dereferencing a NULL pointer in ExprConcatStrings::bindVars(). The fix does change the syntax of the language in some corner cases but I think it's only turning previously invalid (or crashing) syntax to valid syntax. E.g. "a\ b" and ''a''\ b'' were previously syntax errors but now both result in "a\nb". Found by afl-fuzz. 2018-02-25 21:51:47 +00:00			`"a\`
			`b"`