From fe79b13ab2ce9526fae10a5257b4e171cae30ecb Mon Sep 17 00:00:00 2001
From: zeripath <art27@cantab.net>
Date: Tue, 29 Sep 2020 22:26:54 +0100
Subject: [PATCH] Always return a list from GetCommitsFromIDs (#12981)

`GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where
it expects that `c.Commits` is not nil.

This potentially nil set causes a NPE in in #12953

Fix #12953

Signed-off-by: Andrew Thornton <art27@cantab.net>
---
 modules/git/repo_commit.go | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/modules/git/repo_commit.go b/modules/git/repo_commit.go
index 45745c8088..c9a5efb24e 100644
--- a/modules/git/repo_commit.go
+++ b/modules/git/repo_commit.go
@@ -504,10 +504,6 @@ func (repo *Repository) getBranches(commit *Commit, limit int) ([]string, error)
 
 // GetCommitsFromIDs get commits from commit IDs
 func (repo *Repository) GetCommitsFromIDs(commitIDs []string) (commits *list.List) {
-	if len(commitIDs) == 0 {
-		return nil
-	}
-
 	commits = list.New()
 
 	for _, commitID := range commitIDs {