From de6dfb714153c17a06406c866805a17a476c63bd Mon Sep 17 00:00:00 2001
From: Yarden Shoham <hrsi88@gmail.com>
Date: Tue, 15 Nov 2022 04:10:50 +0200
Subject: [PATCH] Remove `href="javascript:;"` in "save topics (Done)" button
(#21813)
To use an anchor tag as a button and have it be accessible I added
`role="button" tabindex="0"`,
[reference](https://stackoverflow.com/a/10510353/7414734).
* Closes #19912
---
templates/repo/home.tmpl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/templates/repo/home.tmpl b/templates/repo/home.tmpl
index 6b4a0008d6..a798d3cc9e 100644
--- a/templates/repo/home.tmpl
+++ b/templates/repo/home.tmpl
@@ -47,7 +47,7 @@
</div>
</div>
<div class="two wide column">
- <a class="ui button primary" href="javascript:;" id="save_topic"
+ <a class="ui button primary" role="button" tabindex="0" id="save_topic"
data-link="{{.RepoLink}}/topics">{{.locale.Tr "repo.topic.done"}}</a>
</div>
</div>