From dac7728e9d05b25f1132deefce92a61afd36973f Mon Sep 17 00:00:00 2001
From: "Panagiotis \"Ivory\" Vasilopoulos" <git@n0toose.net>
Date: Thu, 7 Dec 2023 03:01:32 +0000
Subject: [PATCH] Issue fixes for RSS feed improvements (#28380)
Follow-up for #28368
- Just replace button with an a-element with the button class
- Remove useless link-action class from template/org/home.tmpl
---
templates/org/home.tmpl | 4 ++--
templates/repo/header.tmpl | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl
index a84e3efc89..fc65d4691c 100644
--- a/templates/org/home.tmpl
+++ b/templates/org/home.tmpl
@@ -21,9 +21,9 @@
</div>
<div class="right menu">
{{if .EnableFeed}}
- <button class="link-action ui basic label button gt-mr-0" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}" data-url="{{$.Org.HomeLink}}.rss">
+ <a class="ui basic label button gt-mr-0" href="{{$.Org.HomeLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
{{svg "octicon-rss" 24}}
- </button>
+ </a>
{{end}}
<button class="link-action ui basic button gt-mr-0" data-url="{{.Org.HomeLink}}?action={{if $.IsFollowing}}unfollow{{else}}follow{{end}}">
{{if $.IsFollowing}}
diff --git a/templates/repo/header.tmpl b/templates/repo/header.tmpl
index e4aadf37e3..af00b2b383 100644
--- a/templates/repo/header.tmpl
+++ b/templates/repo/header.tmpl
@@ -54,9 +54,9 @@
{{end}}
{{if $.EnableFeed}}
{{/* An extra div-element is not necessary here, as this button does not secretly contain two buttons. */}}
- <button class="ui compact small basic button" data-url="{{$.RepoLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
+ <a class="ui compact small basic button" href="{{$.RepoLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
{{svg "octicon-rss" 16}}
- </button>
+ </a>
{{end}}
<form method="post" action="{{$.RepoLink}}/action/{{if $.IsWatchingRepo}}un{{end}}watch?redirect_to={{$.Link}}">
{{$.CsrfTokenHtml}}