From 2cf17b13478f810269ddc826d937c4d3e5226a08 Mon Sep 17 00:00:00 2001
From: wxiaoguang <wxiaoguang@gmail.com>
Date: Sat, 12 Apr 2025 18:31:13 +0800
Subject: [PATCH] fix wrong call order
---
web_src/js/webcomponents/overflow-menu.ts | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/web_src/js/webcomponents/overflow-menu.ts b/web_src/js/webcomponents/overflow-menu.ts
index ce8f5c5df0..ae93f2b758 100644
--- a/web_src/js/webcomponents/overflow-menu.ts
+++ b/web_src/js/webcomponents/overflow-menu.ts
@@ -115,6 +115,7 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
const btn = this.querySelector('.overflow-menu-button');
btn?._tippy?.destroy();
btn?.remove();
+ this.button = null;
return;
}
@@ -139,15 +140,12 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
}
// create button initially
- const btn = document.createElement('button');
- btn.classList.add('overflow-menu-button');
- btn.setAttribute('aria-label', window.config.i18n.more_items);
- btn.innerHTML = octiconKebabHorizontal;
- this.append(btn);
- this.button = btn;
- this.updateButtonActivationState();
-
- createTippy(btn, {
+ this.button = document.createElement('button');
+ this.button.classList.add('overflow-menu-button');
+ this.button.setAttribute('aria-label', window.config.i18n.more_items);
+ this.button.innerHTML = octiconKebabHorizontal;
+ this.append(this.button);
+ createTippy(this.button, {
trigger: 'click',
hideOnClick: true,
interactive: true,
@@ -161,6 +159,7 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
}, 0);
},
});
+ this.updateButtonActivationState();
});
init() {