From 7b62d70d184ca9e8e7c6864d6ed39b4e8f75f02f Mon Sep 17 00:00:00 2001
From: Haobo Gu <haobogu@outlook.com>
Date: Fri, 25 Oct 2024 18:27:48 +0800
Subject: [PATCH] feat(ospi): add memory mapped mode

Signed-off-by: Haobo Gu <haobogu@outlook.com>
---
 embassy-stm32/src/ospi/mod.rs | 63 ++++++++++++++++++++++++++---------
 1 file changed, 48 insertions(+), 15 deletions(-)

diff --git a/embassy-stm32/src/ospi/mod.rs b/embassy-stm32/src/ospi/mod.rs
index 0574f7816..7ccafe361 100644
--- a/embassy-stm32/src/ospi/mod.rs
+++ b/embassy-stm32/src/ospi/mod.rs
@@ -179,39 +179,72 @@ pub struct Ospi<'d, T: Instance, M: PeriMode> {
 }
 
 impl<'d, T: Instance, M: PeriMode> Ospi<'d, T, M> {
-    pub fn enable_memory_mapped_mode(&mut self) {
+    /// Enter memory mode.
+    /// The Input `TransferConfig` is used to configure the read operation in memory mode
+    pub fn enable_memory_mapped_mode(
+        &mut self,
+        read_config: TransferConfig,
+        write_config: TransferConfig,
+    ) -> Result<(), OspiError> {
+        // Use configure command to set read config
+        self.configure_command(&read_config, None)?;
+
         let reg = T::REGS;
         while reg.sr().read().busy() {
             info!("wait ospi busy");
         }
-    
+
         reg.ccr().modify(|r| {
-            r.set_isize(crate::ospi::vals::SizeInBits::_8BIT);
-            r.set_adsize(crate::ospi::vals::SizeInBits::_24BIT);
-            r.set_admode(crate::ospi::vals::PhaseMode::ONELINE);
-            r.set_imode(crate::ospi::vals::PhaseMode::ONELINE);
-            r.set_dmode(crate::ospi::vals::PhaseMode::FOURLINES);
+            r.set_dqse(false);
+            r.set_sioo(true);
         });
-    
+
+        // Set wrting configurations, there are separate registers for write configurations in memory mapped mode
+        reg.wccr().modify(|w| {
+            w.set_imode(PhaseMode::from_bits(write_config.iwidth.into()));
+            w.set_idtr(write_config.idtr);
+            w.set_isize(SizeInBits::from_bits(write_config.isize.into()));
+
+            w.set_admode(PhaseMode::from_bits(write_config.adwidth.into()));
+            w.set_addtr(write_config.idtr);
+            w.set_adsize(SizeInBits::from_bits(write_config.adsize.into()));
+
+            w.set_dmode(PhaseMode::from_bits(write_config.dwidth.into()));
+            w.set_ddtr(write_config.ddtr);
+
+            w.set_abmode(PhaseMode::from_bits(write_config.abwidth.into()));
+            w.set_dqse(true);
+        });
+
+        reg.wtcr().modify(|w| w.set_dcyc(write_config.dummy.into()));
+
+        // Enable memory mapped mode
         reg.cr().modify(|r| {
             r.set_fmode(crate::ospi::vals::FunctionalMode::MEMORYMAPPED);
-            r.set_dmaen(false);
-            r.set_en(true);
+            r.set_tcen(false);
         });
-    
-        // reg.tcr().modify(|r| {
-        //     r.set_dcyc(6);
-        // });
-
+        Ok(())
     }
+
+    /// Quit from memory mapped mode
     pub fn disable_memory_mapped_mode(&mut self) {
         let reg = T::REGS;
         while reg.sr().read().busy() {
             info!("wait ospi busy");
         }
+
         reg.cr().modify(|r| {
             r.set_fmode(crate::ospi::vals::FunctionalMode::INDIRECTWRITE);
+            r.set_abort(true);
             r.set_dmaen(false);
+            r.set_en(false);
+        });
+
+        // Clear transfer complete flag
+        reg.fcr().write(|w| w.set_ctcf(true));
+
+        // Re-enable ospi
+        reg.cr().modify(|r| {
             r.set_en(true);
         });
     }