nordic-dev.net/embassy
2
0
Fork 0
mirror of https://github.com/embassy-rs/embassy.git synced 2024-11-22 06:42:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for #3493 - panic! in embassy-usb-synopsys-otg on second serial connection

Browse Source
This commit is contained in:
paulc 2024-11-02 19:19:50 +00:00
parent fcbbef01cd
commit 4b1b7a3508
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
embassy-usb-synopsys-otg/src/lib.rs
View File

@ -43,7 +43,16 @@ pub unsafe fn on_interrupt<const MAX_EP_COUNT: usize>(
let ep_num = status.epnum() as usize;
let len = status.bcnt() as usize;
assert!(ep_num < ep_count);
if ep_num >= ep_count {
// Removed `assert!(ep_num < ep_count);` as this fails for second serial connection UNLESS
// defmt-trace level debugging is enabled embassy-stm32 (note that the defmt feature
// doesnt work in embassy-usb-synopsys-otg as defmt::assert! generates multiple errors)
//
// I'm guessing this may be some sort of timing issue so instead of panic-ing skip
// invalid packet :‑(
error!("Skipping Invalid Packet (ep_num >= ep_count): ep_num: {} ep_count: {}", ep_num, ep_count);
continue;
}
match status.pktstsd() {
vals::Pktstsd::SETUP_DATA_RX => {